fix(lsp): send initial workspace configuration#5277
Merged
Conversation
Sent workspace/didChangeConfiguration after initialized so servers waiting for client configuration finish startup before semantic requests. Added a fake-LSP regression covering notification order and settings payload. Fixes #5276
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro
A focused fake-LSP regression reproduces the startup sequence from #5276:
bun test packages/coding-agent/test/tools/lsp-regressions.test.ts -t "sends initial workspace configuration"failed on the baseline because the client sentinitialize,initialized, thentextDocument/hover;workspace/didChangeConfigurationwas absent.Cause
packages/coding-agent/src/lsp/client.ts#getOrCreateClientadvertisedworkspace.configurationsupport inCLIENT_CAPABILITIES, completedinitialize, sentinitialized, and immediately marked the client ready without sending the initial workspace configuration notification that Pyright waits on before servicing semantic requests.Fix
workspace/didChangeConfigurationwith{ settings: config.settings ?? {} }immediately afterinitializedand before publishing the client as ready.initialize→initialized→workspace/didChangeConfiguration→ semantictextDocument/hover.Verification
bun test packages/coding-agent/test/tools/lsp-regressions.test.ts -t "sends initial workspace configuration"now passes: 1 pass, 0 fail.bun test packages/coding-agent/test/tools/lsp-regressions.test.tspasses: 58 pass, 0 fail.gh_push_branchcompleted the pre-publish gate before pushing. Fixes #5276